Update maximum_line_length to use Checker.noqa - #539
Merged
Conversation
This also updates the Checker to update it's state for physical lines as well as logical lines. This allows maximum_line_length to rely on Checker state for its noqa check. Closes PyCQA#538
sigmavirus24
added a commit
to PyCQA/flake8
that referenced
this pull request
Jun 7, 2016
This adds E501 which is actually a poor test. Currently, pep8.maximum_line_length does its own check for noqa instead of relying on the Checker. See also: PyCQA/pycodestyle#539
Member
|
Thanks @sigmavirus24 ! |
Member
|
A relnote would be good for this as many flake8 plugins could benefit from it, as they often do thier own noqa support. |
Member
Author
|
@jayvdb I'm not sure which plugins do that, but this attribute has been on the Checker for as long as I can remember and has been used by hacking for years. Either way, plugins for Flake8 will be changing drastically in 3.0 so plugins will not have to do their own noqa check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also updates the Checker to update it's state for physical lines
as well as logical lines. This allows maximum_line_length to rely on
Checker state for its noqa check.
Closes #538